[FIX] composer: change mode to editing when composer cursor selection changes #7400
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
rrahir
requested changes
Nov 7, 2025
… changes
Before this commit:
- When typing '=sum(' and pressing the Home key, selecting a range caused weird
behavior in the composer.
- The same issue occurred when using Ctrl+A to select the entire text.
After this commit:
- Changing the cursor selection now correctly switches the mode to 'editing'.
Task: 5226615
rmbh-odoo
force-pushed
the
17.0-fix-composer-range-selection-rmbh
branch
from
6971b3b to
2c38d58
Compare
rmbh-odoo
changed the title
rrahir
reviewed
Nov 10, 2025
Collaborator
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 18, 2025
… changes
Before this commit:
- When typing '=sum(' and pressing the Home key, selecting a range caused weird
behavior in the composer.
- The same issue occurred when using Ctrl+A to select the entire text.
After this commit:
- Changing the cursor selection now correctly switches the mode to 'editing'.
closes #7400
Task: 5226615
Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
This was referenced Nov 18, 2025
rrahir
added a commit
that referenced
this pull request
Nov 20, 2025
Currently, users can modify the input of a composer/selection input while selecting a range in the grid. Those inputs can have side-effect that are difficult to account for as the selection is managed in a hook which is not aware of the related feature that it handles (selection, cell reference, pivot reference, selection input). A recent work to fix that: #7400 Overall, there is no added value to be able to mix writing text while selecting ranges inside the grid so we simply disable that possibility altogether. Task: 5347297
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Current behavior before PR:
=sum(and pressing the Home key, selecting a range caused weirdbehavior in the composer.
Desired behavior after PR is merged:
Task: 5226615
review checklist